cve-2022-48744
Vulnerability from cvelistv5
Published
2024-06-20 11:13
Modified
2024-09-11 17:34
Severity ?
Summary
net/mlx5e: Avoid field-overflowing memcpy()
References
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/8fbdf8c8b8ab82beab882175157650452c46493e
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/ad5185735f7dab342fdd0dd41044da4c9ccfef67
Impacted products
LinuxLinux
LinuxLinux
Show details on NVD website

To clipboard 

{
  "containers": {
    "adp": [
      {
        "providerMetadata": {
          "dateUpdated": "2024-08-03T15:25:00.531Z",
          "orgId": "af854a3a-2127-422b-91ae-364da2661108",
          "shortName": "CVE"
        },
        "references": [
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://git.kernel.org/stable/c/8fbdf8c8b8ab82beab882175157650452c46493e"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://git.kernel.org/stable/c/ad5185735f7dab342fdd0dd41044da4c9ccfef67"
          }
        ],
        "title": "CVE Program Container"
      },
      {
        "metrics": [
          {
            "other": {
              "content": {
                "id": "CVE-2022-48744",
                "options": [
                  {
                    "Exploitation": "none"
                  },
                  {
                    "Automatable": "no"
                  },
                  {
                    "Technical Impact": "partial"
                  }
                ],
                "role": "CISA Coordinator",
                "timestamp": "2024-09-10T17:10:38.103398Z",
                "version": "2.0.3"
              },
              "type": "ssvc"
            }
          }
        ],
        "providerMetadata": {
          "dateUpdated": "2024-09-11T17:34:48.322Z",
          "orgId": "134c704f-9b21-4f2e-91b3-4a467353bcc0",
          "shortName": "CISA-ADP"
        },
        "title": "CISA ADP Vulnrichment"
      }
    ],
    "cna": {
      "affected": [
        {
          "defaultStatus": "unaffected",
          "product": "Linux",
          "programFiles": [
            "drivers/net/ethernet/mellanox/mlx5/core/en.h",
            "drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "lessThan": "8fbdf8c8b8ab",
              "status": "affected",
              "version": "b5503b994ed5",
              "versionType": "git"
            },
            {
              "lessThan": "ad5185735f7d",
              "status": "affected",
              "version": "b5503b994ed5",
              "versionType": "git"
            }
          ]
        },
        {
          "defaultStatus": "affected",
          "product": "Linux",
          "programFiles": [
            "drivers/net/ethernet/mellanox/mlx5/core/en.h",
            "drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "status": "affected",
              "version": "4.9"
            },
            {
              "lessThan": "4.9",
              "status": "unaffected",
              "version": "0",
              "versionType": "custom"
            },
            {
              "lessThanOrEqual": "5.16.*",
              "status": "unaffected",
              "version": "5.16.6",
              "versionType": "custom"
            },
            {
              "lessThanOrEqual": "*",
              "status": "unaffected",
              "version": "5.17",
              "versionType": "original_commit_for_fix"
            }
          ]
        }
      ],
      "descriptions": [
        {
          "lang": "en",
          "value": "In the Linux kernel, the following vulnerability has been resolved:\n\nnet/mlx5e: Avoid field-overflowing memcpy()\n\nIn preparation for FORTIFY_SOURCE performing compile-time and run-time\nfield bounds checking for memcpy(), memmove(), and memset(), avoid\nintentionally writing across neighboring fields.\n\nUse flexible arrays instead of zero-element arrays (which look like they\nare always overflowing) and split the cross-field memcpy() into two halves\nthat can be appropriately bounds-checked by the compiler.\n\nWe were doing:\n\n\t#define ETH_HLEN  14\n\t#define VLAN_HLEN  4\n\t...\n\t#define MLX5E_XDP_MIN_INLINE (ETH_HLEN + VLAN_HLEN)\n\t...\n        struct mlx5e_tx_wqe      *wqe  = mlx5_wq_cyc_get_wqe(wq, pi);\n\t...\n        struct mlx5_wqe_eth_seg  *eseg = \u0026wqe-\u003eeth;\n        struct mlx5_wqe_data_seg *dseg = wqe-\u003edata;\n\t...\n\tmemcpy(eseg-\u003einline_hdr.start, xdptxd-\u003edata, MLX5E_XDP_MIN_INLINE);\n\ntarget is wqe-\u003eeth.inline_hdr.start (which the compiler sees as being\n2 bytes in size), but copying 18, intending to write across start\n(really vlan_tci, 2 bytes). The remaining 16 bytes get written into\nwqe-\u003edata[0], covering byte_count (4 bytes), lkey (4 bytes), and addr\n(8 bytes).\n\nstruct mlx5e_tx_wqe {\n        struct mlx5_wqe_ctrl_seg   ctrl;                 /*     0    16 */\n        struct mlx5_wqe_eth_seg    eth;                  /*    16    16 */\n        struct mlx5_wqe_data_seg   data[];               /*    32     0 */\n\n        /* size: 32, cachelines: 1, members: 3 */\n        /* last cacheline: 32 bytes */\n};\n\nstruct mlx5_wqe_eth_seg {\n        u8                         swp_outer_l4_offset;  /*     0     1 */\n        u8                         swp_outer_l3_offset;  /*     1     1 */\n        u8                         swp_inner_l4_offset;  /*     2     1 */\n        u8                         swp_inner_l3_offset;  /*     3     1 */\n        u8                         cs_flags;             /*     4     1 */\n        u8                         swp_flags;            /*     5     1 */\n        __be16                     mss;                  /*     6     2 */\n        __be32                     flow_table_metadata;  /*     8     4 */\n        union {\n                struct {\n                        __be16     sz;                   /*    12     2 */\n                        u8         start[2];             /*    14     2 */\n                } inline_hdr;                            /*    12     4 */\n                struct {\n                        __be16     type;                 /*    12     2 */\n                        __be16     vlan_tci;             /*    14     2 */\n                } insert;                                /*    12     4 */\n                __be32             trailer;              /*    12     4 */\n        };                                               /*    12     4 */\n\n        /* size: 16, cachelines: 1, members: 9 */\n        /* last cacheline: 16 bytes */\n};\n\nstruct mlx5_wqe_data_seg {\n        __be32                     byte_count;           /*     0     4 */\n        __be32                     lkey;                 /*     4     4 */\n        __be64                     addr;                 /*     8     8 */\n\n        /* size: 16, cachelines: 1, members: 3 */\n        /* last cacheline: 16 bytes */\n};\n\nSo, split the memcpy() so the compiler can reason about the buffer\nsizes.\n\n\"pahole\" shows no size nor member offset changes to struct mlx5e_tx_wqe\nnor struct mlx5e_umr_wqe. \"objdump -d\" shows no meaningful object\ncode changes (i.e. only source line number induced differences and\noptimizations)."
        }
      ],
      "providerMetadata": {
        "dateUpdated": "2024-06-20T11:14:35.699Z",
        "orgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
        "shortName": "Linux"
      },
      "references": [
        {
          "url": "https://git.kernel.org/stable/c/8fbdf8c8b8ab82beab882175157650452c46493e"
        },
        {
          "url": "https://git.kernel.org/stable/c/ad5185735f7dab342fdd0dd41044da4c9ccfef67"
        }
      ],
      "title": "net/mlx5e: Avoid field-overflowing memcpy()",
      "x_generator": {
        "engine": "bippy-7d53e8ef8be4"
      }
    }
  },
  "cveMetadata": {
    "assignerOrgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
    "assignerShortName": "Linux",
    "cveId": "CVE-2022-48744",
    "datePublished": "2024-06-20T11:13:27.979Z",
    "dateReserved": "2024-06-20T11:09:39.055Z",
    "dateUpdated": "2024-09-11T17:34:48.322Z",
    "state": "PUBLISHED"
  },
  "dataType": "CVE_RECORD",
  "dataVersion": "5.1",
  "meta": {
    "nvd": "{\"cve\":{\"id\":\"CVE-2022-48744\",\"sourceIdentifier\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\",\"published\":\"2024-06-20T12:15:12.700\",\"lastModified\":\"2024-06-20T12:43:25.663\",\"vulnStatus\":\"Awaiting Analysis\",\"descriptions\":[{\"lang\":\"en\",\"value\":\"In the Linux kernel, the following vulnerability has been resolved:\\n\\nnet/mlx5e: Avoid field-overflowing memcpy()\\n\\nIn preparation for FORTIFY_SOURCE performing compile-time and run-time\\nfield bounds checking for memcpy(), memmove(), and memset(), avoid\\nintentionally writing across neighboring fields.\\n\\nUse flexible arrays instead of zero-element arrays (which look like they\\nare always overflowing) and split the cross-field memcpy() into two halves\\nthat can be appropriately bounds-checked by the compiler.\\n\\nWe were doing:\\n\\n\\t#define ETH_HLEN  14\\n\\t#define VLAN_HLEN  4\\n\\t...\\n\\t#define MLX5E_XDP_MIN_INLINE (ETH_HLEN + VLAN_HLEN)\\n\\t...\\n        struct mlx5e_tx_wqe      *wqe  = mlx5_wq_cyc_get_wqe(wq, pi);\\n\\t...\\n        struct mlx5_wqe_eth_seg  *eseg = \u0026wqe-\u003eeth;\\n        struct mlx5_wqe_data_seg *dseg = wqe-\u003edata;\\n\\t...\\n\\tmemcpy(eseg-\u003einline_hdr.start, xdptxd-\u003edata, MLX5E_XDP_MIN_INLINE);\\n\\ntarget is wqe-\u003eeth.inline_hdr.start (which the compiler sees as being\\n2 bytes in size), but copying 18, intending to write across start\\n(really vlan_tci, 2 bytes). The remaining 16 bytes get written into\\nwqe-\u003edata[0], covering byte_count (4 bytes), lkey (4 bytes), and addr\\n(8 bytes).\\n\\nstruct mlx5e_tx_wqe {\\n        struct mlx5_wqe_ctrl_seg   ctrl;                 /*     0    16 */\\n        struct mlx5_wqe_eth_seg    eth;                  /*    16    16 */\\n        struct mlx5_wqe_data_seg   data[];               /*    32     0 */\\n\\n        /* size: 32, cachelines: 1, members: 3 */\\n        /* last cacheline: 32 bytes */\\n};\\n\\nstruct mlx5_wqe_eth_seg {\\n        u8                         swp_outer_l4_offset;  /*     0     1 */\\n        u8                         swp_outer_l3_offset;  /*     1     1 */\\n        u8                         swp_inner_l4_offset;  /*     2     1 */\\n        u8                         swp_inner_l3_offset;  /*     3     1 */\\n        u8                         cs_flags;             /*     4     1 */\\n        u8                         swp_flags;            /*     5     1 */\\n        __be16                     mss;                  /*     6     2 */\\n        __be32                     flow_table_metadata;  /*     8     4 */\\n        union {\\n                struct {\\n                        __be16     sz;                   /*    12     2 */\\n                        u8         start[2];             /*    14     2 */\\n                } inline_hdr;                            /*    12     4 */\\n                struct {\\n                        __be16     type;                 /*    12     2 */\\n                        __be16     vlan_tci;             /*    14     2 */\\n                } insert;                                /*    12     4 */\\n                __be32             trailer;              /*    12     4 */\\n        };                                               /*    12     4 */\\n\\n        /* size: 16, cachelines: 1, members: 9 */\\n        /* last cacheline: 16 bytes */\\n};\\n\\nstruct mlx5_wqe_data_seg {\\n        __be32                     byte_count;           /*     0     4 */\\n        __be32                     lkey;                 /*     4     4 */\\n        __be64                     addr;                 /*     8     8 */\\n\\n        /* size: 16, cachelines: 1, members: 3 */\\n        /* last cacheline: 16 bytes */\\n};\\n\\nSo, split the memcpy() so the compiler can reason about the buffer\\nsizes.\\n\\n\\\"pahole\\\" shows no size nor member offset changes to struct mlx5e_tx_wqe\\nnor struct mlx5e_umr_wqe. \\\"objdump -d\\\" shows no meaningful object\\ncode changes (i.e. only source line number induced differences and\\noptimizations).\"}],\"metrics\":{},\"references\":[{\"url\":\"https://git.kernel.org/stable/c/8fbdf8c8b8ab82beab882175157650452c46493e\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"},{\"url\":\"https://git.kernel.org/stable/c/ad5185735f7dab342fdd0dd41044da4c9ccfef67\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"}]}}"
  }
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.