GHSA-4XW9-CX39-R355

Vulnerability from github – Published: 2023-11-17 22:48 – Updated: 2026-06-08 23:38
VLAI
Summary
json-web-token library is vulnerable to a JWT algorithm confusion attack
Details

Summary

The json-web-token library is vulnerable to a JWT algorithm confusion attack.

Details

On line 86 of the 'index.js' file, the algorithm to use for verifying the signature of the JWT token is taken from the JWT token, which at that point is still unverified and thus shouldn't be trusted. To exploit this vulnerability, an attacker needs to craft a malicious JWT token containing the HS256 algorithm, signed with the public RSA key of the victim application. This attack will only work against this library is the RS256 algorithm is in use, however it is a best practice to use that algorithm.

PoC

Take a server running the following code:

const express = require('express');
const jwt = require('json-web-token');
const fs = require('fs');
const path = require('path');

const app = express();
const port = 3000;

// Load the keys from the file
const publicKeyPath = path.join(__dirname, 'public-key.pem');
const publicKey = fs.readFileSync(publicKeyPath, 'utf8');
const privateKeyPath = path.join(__dirname, 'private-key.pem');
const privateKey = fs.readFileSync(privateKeyPath, 'utf8');

app.use(express.json());

// Endpoint to generate a JWT token with admin: False
app.get('/generateToken', async (req, res) => {
  const payload = { admin: false, name: req.query.name };
  const token = await jwt.encode(privateKey, payload, 'RS256', function (err, token) {
    res.json({ token });
  });
});

// Middleware to verify the JWT token
function verifyToken(req, res, next) {
  const token = req.query.token;

  jwt.decode(publicKey, token, (err, decoded) => {
    if (err) {
      console.log(err)
      return res.status(401).json({ message: 'Token authentication failed' });
    }

    req.decoded = decoded;
    next();
  });
}

// Endpoint to check if you are the admin or not
app.get('/checkAdmin', verifyToken, (req, res) => {
  res.json(req.decoded);
});

app.listen(port, () => {
  console.log(`Server is running on port ${port}`);
});

Public key recovery First, an attacker needs to recover the public key from the server in any way possible. It is possible to extract this from just two JWT tokens as shown below. Grab two different JWT tokens and utilize the following tool: https://github.com/silentsignal/rsa_sign2n/blob/release/standalone/jwt_forgery.py

python3 jwt_forgery.py token1 token2

The tool will generate 4 different public keys, all in different formats. Try the following for all 4 formats.

Algorithm confusion Change the JWT to the HS256 algorithm and modify any of the contents to your liking at https://jwt.io/. Copy the resulting JWT token and use with the following tool: https://github.com/ticarpi/jwt_tool.

python /opt/jwt_tool/jwt_tool.py --exploit k -pk public_key token

You will now get a resulting JWT token that is validly signed.

Impact

Applications using the RS256 algorithm, are vulnerable to this algorithm confusion attack which allows attackers to sign arbitrary payloads that the verifier will accept.

Solution

Either one of the following solutions will work. 1. Change the signature of the decode function to ensure that the algorithm is set in that call 2. Check whether or not the secret could be a public key in the decode function and in that case, set the key to be a public key.

Fixed in 4.0.0. Both encode and decode now reject combinations where the key type (PEM vs plain secret) doesn't match the algorithm family. Upgrade with npm install json-web-token@^4.

Show details on source website

{
  "affected": [
    {
      "database_specific": {
        "last_known_affected_version_range": "\u003c= 3.1.1"
      },
      "package": {
        "ecosystem": "npm",
        "name": "json-web-token"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "0"
            },
            {
              "fixed": "4.0.0"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    }
  ],
  "aliases": [
    "CVE-2023-48238"
  ],
  "database_specific": {
    "cwe_ids": [
      "CWE-20",
      "CWE-345"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2023-11-17T22:48:15Z",
    "nvd_published_at": "2023-11-17T22:15:07Z",
    "severity": "HIGH"
  },
  "details": "### Summary\nThe json-web-token library is vulnerable to a JWT algorithm confusion attack.\n\n### Details\nOn line 86 of the \u0027index.js\u0027 file, the algorithm to use for verifying the signature of the JWT token is taken from the JWT token, which at that point is still unverified and thus shouldn\u0027t be trusted. To exploit this vulnerability, an attacker needs to craft a malicious JWT token containing the HS256 algorithm, signed with the public RSA key of the victim application. This attack will only work against this library is the RS256 algorithm is in use, however it is a best practice to use that algorithm.\n\n### PoC\nTake a server running the following code:\n```javascript\nconst express = require(\u0027express\u0027);\nconst jwt = require(\u0027json-web-token\u0027);\nconst fs = require(\u0027fs\u0027);\nconst path = require(\u0027path\u0027);\n\nconst app = express();\nconst port = 3000;\n\n// Load the keys from the file\nconst publicKeyPath = path.join(__dirname, \u0027public-key.pem\u0027);\nconst publicKey = fs.readFileSync(publicKeyPath, \u0027utf8\u0027);\nconst privateKeyPath = path.join(__dirname, \u0027private-key.pem\u0027);\nconst privateKey = fs.readFileSync(privateKeyPath, \u0027utf8\u0027);\n\napp.use(express.json());\n\n// Endpoint to generate a JWT token with admin: False\napp.get(\u0027/generateToken\u0027, async (req, res) =\u003e {\n  const payload = { admin: false, name: req.query.name };\n  const token = await jwt.encode(privateKey, payload, \u0027RS256\u0027, function (err, token) {\n    res.json({ token });\n  });\n});\n\n// Middleware to verify the JWT token\nfunction verifyToken(req, res, next) {\n  const token = req.query.token;\n\n  jwt.decode(publicKey, token, (err, decoded) =\u003e {\n    if (err) {\n      console.log(err)\n      return res.status(401).json({ message: \u0027Token authentication failed\u0027 });\n    }\n\n    req.decoded = decoded;\n    next();\n  });\n}\n\n// Endpoint to check if you are the admin or not\napp.get(\u0027/checkAdmin\u0027, verifyToken, (req, res) =\u003e {\n  res.json(req.decoded);\n});\n\napp.listen(port, () =\u003e {\n  console.log(`Server is running on port ${port}`);\n});\n```\n\n**Public key recovery**\nFirst, an attacker needs to recover the public key from the server in any way possible. It is possible to extract this from just two JWT tokens as shown below.\nGrab two different JWT tokens and utilize the following tool: `https://github.com/silentsignal/rsa_sign2n/blob/release/standalone/jwt_forgery.py`\n```\npython3 jwt_forgery.py token1 token2\n```\nThe tool will generate 4 different public keys, all in different formats. Try the following for all 4 formats.\n\n**Algorithm confusion**\nChange the JWT to the HS256 algorithm and modify any of the contents to your liking at `https://jwt.io/`.\nCopy the resulting JWT token and use with the following tool: `https://github.com/ticarpi/jwt_tool`.\n```\npython /opt/jwt_tool/jwt_tool.py --exploit k -pk public_key token\n```\nYou will now get a resulting JWT token that is validly signed.\n\n### Impact\nApplications using the RS256 algorithm, are vulnerable to this algorithm confusion attack which allows attackers to sign arbitrary payloads that the verifier will accept.\n\n### Solution\nEither one of the following solutions will work.\n1. Change the signature of the `decode` function to ensure that the algorithm is set in that call\n2. Check whether or not the secret could be a public key in the decode function and in that case, set the key to be a public key.\n\n\n\u003e Fixed in 4.0.0. Both encode and decode now reject combinations where the key type (PEM vs plain secret) doesn\u0027t match the algorithm family. Upgrade with npm install json-web-token@^4.",
  "id": "GHSA-4xw9-cx39-r355",
  "modified": "2026-06-08T23:38:28Z",
  "published": "2023-11-17T22:48:15Z",
  "references": [
    {
      "type": "WEB",
      "url": "https://github.com/joaquimserafim/json-web-token/security/advisories/GHSA-4xw9-cx39-r355"
    },
    {
      "type": "ADVISORY",
      "url": "https://nvd.nist.gov/vuln/detail/CVE-2023-48238"
    },
    {
      "type": "WEB",
      "url": "https://github.com/joaquimserafim/json-web-token/commit/b6e56b1346f48432d29133c76b65222ad93956b7"
    },
    {
      "type": "PACKAGE",
      "url": "https://github.com/joaquimserafim/json-web-token"
    },
    {
      "type": "WEB",
      "url": "https://github.com/joaquimserafim/json-web-token/blob/acf6a462471e1b14187eb77414e9161b8b7bff7e/index.js#L86"
    }
  ],
  "schema_version": "1.4.0",
  "severity": [
    {
      "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N",
      "type": "CVSS_V3"
    }
  ],
  "summary": "json-web-token library is vulnerable to a JWT algorithm confusion attack"
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.


Loading…

Loading…

Loading…

Forecast uses a logistic model when the trend is rising, or an exponential decay model when the trend is falling. Fitted via linearized least squares.

Sightings

Author Source Type Date Other

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or observed by the user.
  • Confirmed: The vulnerability has been validated from an analyst's perspective.
  • Published Proof of Concept: A public proof of concept is available for this vulnerability.
  • Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
  • Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
  • Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
  • Not confirmed: The user expressed doubt about the validity of the vulnerability.
  • Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.

Loading…

Detection rules are retrieved from Rulezet.

Loading…

Loading…