GHSA-9H9Q-QHXG-89XR
Vulnerability from github – Published: 2024-09-27 20:51 – Updated: 2024-10-23 17:40Summary
If values passed to a ColorColumn or ColumnEntry are not valid and contain a specific set of characters, applications are vulnerable to XSS attack against a user who opens a page on which a color column or entry is rendered.
Versions of Filament from v3.0.0 through v3.2.114 are affected.
Please upgrade to Filament v3.2.115.
PoC
For example, using a value such as:
blue;"><script>alert('There\'s a security problem here')</script style="
Would get passed into the @style() Blade directive from Laravel to render the correct background color, where $state contains the value:
<div @style([
"background-color: {$state}" => $state,
])></div>
Since Laravel does not escape special characters within the @style Blade directive, the effective output HTML would be:
<div style="background-color: blue;"><script>alert('There\'s a security problem here')</script style=""></div>
Creating the opportunity for arbitrary JS to run if it was stored in the database.
Response
This vulnerability (in ColorColumn only) was reported by @sv-LayZ, who reported the issue and patched the issue during the evening of 25/09/2024. Thank you Mattis.
The review process concluded on 27/09/2024, which revealed the issue was also present in ColorEntry. This was fixed the same day and Filament v3.2.115 followed to escape any special characters while outputting inline styles like this:
<div @style([
'background-color: ' . e($state) => $state,
])></div>
Although these components are no longer vulnerable to this type of XSS attack, it is good practice to validate colors, and since many Filament users may be accepting color input using the ColorPicker form component, additional color validation documentation was published.
{
"affected": [
{
"package": {
"ecosystem": "Packagist",
"name": "filament/tables"
},
"ranges": [
{
"events": [
{
"introduced": "3.0.0"
},
{
"fixed": "3.2.115"
}
],
"type": "ECOSYSTEM"
}
]
},
{
"package": {
"ecosystem": "Packagist",
"name": "filament/infolists"
},
"ranges": [
{
"events": [
{
"introduced": "3.0.0"
},
{
"fixed": "3.2.115"
}
],
"type": "ECOSYSTEM"
}
]
}
],
"aliases": [
"CVE-2024-47186"
],
"database_specific": {
"cwe_ids": [
"CWE-79"
],
"github_reviewed": true,
"github_reviewed_at": "2024-09-27T20:51:01Z",
"nvd_published_at": "2024-09-27T21:15:03Z",
"severity": "CRITICAL"
},
"details": "### Summary\n\nIf values passed to a `ColorColumn` or `ColumnEntry` are not valid and contain a specific set of characters, applications are vulnerable to XSS attack against a user who opens a page on which a color column or entry is rendered.\n\nVersions of Filament from v3.0.0 through v3.2.114 are affected.\n\nPlease upgrade to Filament [v3.2.115](https://github.com/filamentphp/filament/releases/tag/v3.2.115).\n\n### PoC\n\nFor example, using a value such as:\n\n```html\nblue;\"\u003e\u003cscript\u003ealert(\u0027There\\\u0027s a security problem here\u0027)\u003c/script style=\"\n```\n\nWould get passed into the `@style()` Blade directive from Laravel to render the correct background color, where `$state` contains the value:\n\n```blade\n\u003cdiv @style([\n \"background-color: {$state}\" =\u003e $state,\n])\u003e\u003c/div\u003e\n```\n\nSince Laravel does not escape special characters within the `@style` Blade directive, the effective output HTML would be:\n\n```html\n\u003cdiv style=\"background-color: blue;\"\u003e\u003cscript\u003ealert(\u0027There\\\u0027s a security problem here\u0027)\u003c/script style=\"\"\u003e\u003c/div\u003e\n```\n\nCreating the opportunity for arbitrary JS to run if it was stored in the database.\n\n### Response\n\nThis vulnerability (in `ColorColumn` only) was reported by @sv-LayZ, who reported the issue and patched the issue during the evening of 25/09/2024. Thank you Mattis.\n\nThe review process concluded on 27/09/2024, which revealed the issue was also present in `ColorEntry`. This was fixed the same day and Filament [v3.2.115](https://github.com/filamentphp/filament/releases/tag/v3.2.115) followed to escape any special characters while outputting inline styles like this:\n\n```blade\n\u003cdiv @style([\n \u0027background-color: \u0027 . e($state) =\u003e $state,\n])\u003e\u003c/div\u003e\n```\n\nAlthough these components are no longer vulnerable to this type of XSS attack, it is good practice to validate colors, and since many Filament users may be accepting color input using the `ColorPicker` form component, [additional color validation documentation was published](https://filamentphp.com/docs/3.x/forms/fields/color-picker#color-picker-validation).",
"id": "GHSA-9h9q-qhxg-89xr",
"modified": "2024-10-23T17:40:43Z",
"published": "2024-09-27T20:51:01Z",
"references": [
{
"type": "WEB",
"url": "https://github.com/filamentphp/filament/security/advisories/GHSA-9h9q-qhxg-89xr"
},
{
"type": "WEB",
"url": "https://github.com/filamentphp/filament/commit/df7989352464d08eda5837ef50f9997fad902316"
},
{
"type": "PACKAGE",
"url": "https://github.com/filamentphp/filament"
},
{
"type": "WEB",
"url": "https://github.com/filamentphp/filament/releases/tag/v3.2.115"
}
],
"schema_version": "1.4.0",
"severity": [],
"summary": "Filament has unvalidated ColorColumn and ColorEntry values that can be used for Cross-site Scripting"
}
Sightings
| Author | Source | Type | Date |
|---|
Nomenclature
- Seen: The vulnerability was mentioned, discussed, or observed by the user.
- Confirmed: The vulnerability has been validated from an analyst's perspective.
- Published Proof of Concept: A public proof of concept is available for this vulnerability.
- Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
- Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
- Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
- Not confirmed: The user expressed doubt about the validity of the vulnerability.
- Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.