GHSA-CQ9C-6W48-QMFG
Vulnerability from github – Published: 2026-06-22 23:19 – Updated: 2026-06-22 23:19Summary
In OpenID multi-user mode, disabling a user only blocks future OpenID login for that identity. Existing Actual session tokens for the disabled user remain valid, so the user can continue calling authenticated server endpoints after an administrator has disabled the account.
Details
The disabled-user check is present during OpenID login finalization. Existing users are only accepted when the matching row has enabled = 1, and a disabled row causes the OpenID grant to fail before a new session token is created.
// packages/sync-server/src/accounts/openid.ts:284-291
const { id: userIdFromDb, display_name: displayName } =
accountDb.first(
'SELECT id, display_name FROM users WHERE user_name = ? and enabled = 1',
[identity],
) || {};
if (userIdFromDb == null) {
throw new Error('openid-grant-failed');
}
The shared session validation path does not perform the same enabled-user check. It accepts any existing token row that has not expired, then returns the session object to every route protected by validateSessionMiddleware.
// packages/sync-server/src/util/validate-user.ts:10-41
export function validateSession(req: Request, res: Response) {
let { token } = req.body || {};
if (!token) {
token = req.headers['x-actual-token'];
}
const session = getSession(token);
...
return session;
}
This means account disablement and session authorization diverge:
OpenID login path: users.enabled must be 1
Existing session path: token exists and is not expired; users.enabled is not checked
The default token expiration setting is never, so this is not just a short race after disablement on default deployments.
// packages/sync-server/src/load-config.js:260-264
token_expiration: {
doc: 'Token expiration time.',
format: 'tokenExpiration',
default: 'never',
env: 'ACTUAL_TOKEN_EXPIRATION',
},
Admins can change a user's enabled state through the user update route, but that update does not delete the user's existing sessions. After the update, the old token still satisfies validateSession.
// packages/sync-server/src/app-admin.js:91-101
app.patch('/users', validateSessionMiddleware, async (req, res) => {
if (!isAdmin(res.locals.user_id)) {
...
}
const { id, userName, role, displayName, enabled } = req.body || {};
// packages/sync-server/src/services/user-service.ts:98-102
getAccountDb().mutate(
'UPDATE users SET user_name = ?, display_name = ?, enabled = ?, role = ? WHERE id = ?',
[userName, displayName, enabled, roleId, userId],
);
Authenticated server features then continue to trust that session. For example, the sync API installs validateSessionMiddleware for the whole router, so a disabled user can keep using any sync operation that their still-valid session and existing file ownership/access allow.
// packages/sync-server/src/app-sync.ts:37-39
const app = express();
app.use(validateSessionMiddleware);
app.use(errorMiddleware);
This is distinct from the previously published cross-user sync authorization issue: the attacker does not need to access another user's file ID. The bypass is that a disabled user's own session remains authorized after account disablement.
PoC
- Run an Actual Sync Server in OpenID multi-user mode with
@actual-app/sync-server26.5.0. Use the default token expiration setting, or any setting where the token has not expired yet. - Log in as a non-admin OpenID user and save the returned Actual session token.
- As an admin, disable that same user through
PATCH /admin/usersby sendingenabled: false. - Reuse the old token against a protected endpoint.
Example success check:
curl -s https://actual.example.com/account/validate \
-H 'X-Actual-Token: <disabled_user_existing_token>'
Expected result on the affected code path: the request is still treated as authenticated and returns the disabled user's account/session information instead of 401 or 403.
A sync-facing check uses the same session validation primitive:
curl -s https://actual.example.com/sync/list-user-files \
-H 'X-Actual-Token: <disabled_user_existing_token>'
Expected result on the affected code path: the disabled user can still list and operate on budget files that the stale session is otherwise allowed to access.
Impact
A disabled OpenID user can keep post-authentication access until the session row is deleted or expires. With the default token_expiration: never, this can persist indefinitely.
For a disabled basic user, the confirmed impact is continued access to that user's own budgets and any budgets shared with that user, including sensitive financial data and allowed mutations. For a disabled admin user, the impact is broader because the existing token can still satisfy admin role checks; that condition preserves administrative access after the account was disabled.
The missing rule is that session validation should reject disabled users, and disabling or deleting a user should revoke that user's existing sessions.
{
"affected": [
{
"database_specific": {
"last_known_affected_version_range": "\u003c= 26.5.2"
},
"package": {
"ecosystem": "npm",
"name": "@actual-app/sync-server"
},
"ranges": [
{
"events": [
{
"introduced": "0"
},
{
"fixed": "26.6.0"
}
],
"type": "ECOSYSTEM"
}
]
}
],
"aliases": [
"CVE-2026-49229"
],
"database_specific": {
"cwe_ids": [
"CWE-613"
],
"github_reviewed": true,
"github_reviewed_at": "2026-06-22T23:19:56Z",
"nvd_published_at": null,
"severity": "HIGH"
},
"details": "### Summary\n\nIn OpenID multi-user mode, disabling a user only blocks future OpenID login for that identity. Existing Actual session tokens for the disabled user remain valid, so the user can continue calling authenticated server endpoints after an administrator has disabled the account.\n\n### Details\n\nThe disabled-user check is present during OpenID login finalization. Existing users are only accepted when the matching row has `enabled = 1`, and a disabled row causes the OpenID grant to fail before a new session token is created.\n\n```ts\n// packages/sync-server/src/accounts/openid.ts:284-291\nconst { id: userIdFromDb, display_name: displayName } =\n accountDb.first(\n \u0027SELECT id, display_name FROM users WHERE user_name = ? and enabled = 1\u0027,\n [identity],\n ) || {};\n\nif (userIdFromDb == null) {\n throw new Error(\u0027openid-grant-failed\u0027);\n}\n```\n\nThe shared session validation path does not perform the same enabled-user check. It accepts any existing token row that has not expired, then returns the session object to every route protected by `validateSessionMiddleware`.\n\n```ts\n// packages/sync-server/src/util/validate-user.ts:10-41\nexport function validateSession(req: Request, res: Response) {\n let { token } = req.body || {};\n if (!token) {\n token = req.headers[\u0027x-actual-token\u0027];\n }\n\n const session = getSession(token);\n ...\n return session;\n}\n```\n\nThis means account disablement and session authorization diverge:\n\n```text\nOpenID login path: users.enabled must be 1\nExisting session path: token exists and is not expired; users.enabled is not checked\n```\n\nThe default token expiration setting is `never`, so this is not just a short race after disablement on default deployments.\n\n```js\n// packages/sync-server/src/load-config.js:260-264\ntoken_expiration: {\n doc: \u0027Token expiration time.\u0027,\n format: \u0027tokenExpiration\u0027,\n default: \u0027never\u0027,\n env: \u0027ACTUAL_TOKEN_EXPIRATION\u0027,\n},\n```\n\nAdmins can change a user\u0027s enabled state through the user update route, but that update does not delete the user\u0027s existing sessions. After the update, the old token still satisfies `validateSession`.\n\n```js\n// packages/sync-server/src/app-admin.js:91-101\napp.patch(\u0027/users\u0027, validateSessionMiddleware, async (req, res) =\u003e {\n if (!isAdmin(res.locals.user_id)) {\n ...\n }\n\n const { id, userName, role, displayName, enabled } = req.body || {};\n```\n\n```ts\n// packages/sync-server/src/services/user-service.ts:98-102\ngetAccountDb().mutate(\n \u0027UPDATE users SET user_name = ?, display_name = ?, enabled = ?, role = ? WHERE id = ?\u0027,\n [userName, displayName, enabled, roleId, userId],\n);\n```\n\nAuthenticated server features then continue to trust that session. For example, the sync API installs `validateSessionMiddleware` for the whole router, so a disabled user can keep using any sync operation that their still-valid session and existing file ownership/access allow.\n\n```ts\n// packages/sync-server/src/app-sync.ts:37-39\nconst app = express();\napp.use(validateSessionMiddleware);\napp.use(errorMiddleware);\n```\n\nThis is distinct from the previously published cross-user sync authorization issue: the attacker does not need to access another user\u0027s file ID. The bypass is that a disabled user\u0027s own session remains authorized after account disablement.\n\n### PoC\n\n1. Run an Actual Sync Server in OpenID multi-user mode with `@actual-app/sync-server` 26.5.0. Use the default token expiration setting, or any setting where the token has not expired yet.\n2. Log in as a non-admin OpenID user and save the returned Actual session token.\n3. As an admin, disable that same user through `PATCH /admin/users` by sending `enabled: false`.\n4. Reuse the old token against a protected endpoint.\n\nExample success check:\n\n```bash\ncurl -s https://actual.example.com/account/validate \\\n -H \u0027X-Actual-Token: \u003cdisabled_user_existing_token\u003e\u0027\n```\n\nExpected result on the affected code path: the request is still treated as authenticated and returns the disabled user\u0027s account/session information instead of `401` or `403`.\n\nA sync-facing check uses the same session validation primitive:\n\n```bash\ncurl -s https://actual.example.com/sync/list-user-files \\\n -H \u0027X-Actual-Token: \u003cdisabled_user_existing_token\u003e\u0027\n```\n\nExpected result on the affected code path: the disabled user can still list and operate on budget files that the stale session is otherwise allowed to access.\n\n### Impact\n\nA disabled OpenID user can keep post-authentication access until the session row is deleted or expires. With the default `token_expiration: never`, this can persist indefinitely.\n\nFor a disabled basic user, the confirmed impact is continued access to that user\u0027s own budgets and any budgets shared with that user, including sensitive financial data and allowed mutations. For a disabled admin user, the impact is broader because the existing token can still satisfy admin role checks; that condition preserves administrative access after the account was disabled.\n\nThe missing rule is that session validation should reject disabled users, and disabling or deleting a user should revoke that user\u0027s existing sessions.",
"id": "GHSA-cq9c-6w48-qmfg",
"modified": "2026-06-22T23:19:56Z",
"published": "2026-06-22T23:19:56Z",
"references": [
{
"type": "WEB",
"url": "https://github.com/actualbudget/actual/security/advisories/GHSA-cq9c-6w48-qmfg"
},
{
"type": "PACKAGE",
"url": "https://github.com/actualbudget/actual"
}
],
"schema_version": "1.4.0",
"severity": [
{
"score": "CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:L",
"type": "CVSS_V3"
}
],
"summary": "@actual-app/sync-server: Disabled OpenID users keep access through existing session tokens"
}
Sightings
| Author | Source | Type | Date | Other |
|---|
Nomenclature
- Seen: The vulnerability was mentioned, discussed, or observed by the user.
- Confirmed: The vulnerability has been validated from an analyst's perspective.
- Published Proof of Concept: A public proof of concept is available for this vulnerability.
- Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
- Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
- Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
- Not confirmed: The user expressed doubt about the validity of the vulnerability.
- Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.