GHSA-QJMQ-8HJR-QCV6

Vulnerability from github – Published: 2022-04-07 15:18 – Updated: 2022-04-18 22:20
VLAI?
Summary
SQL Injection when creating an application with Reactive SQL backend
Details

Impact

SQL Injection vulnerability in entities for applications generated with the option "reactive with Spring WebFlux" enabled and an SQL database using r2dbc. Applications created without "reactive with Spring WebFlux" and applications with NoSQL databases are not affected.

If you have generated a microservice Gateway using the affected version, you might be impacted as Gateways are reactive by default.

Currently, SQL injection is possible in the findAllBy(Pageable pageable, Criteria criteria) method of an entity repository class generated in these applications as the where clause using Criteria for queries are not sanitized and user input is passed on as it is by the criteria.

Impacted applications

  • Monolith and microservice applications with SQL database and reactive with Spring WebFlux combination (other combinations are not affected and the issue is only present when you generate entities)
  • Gateway applications with SQL database (issue will appear only when generating entities)

Patches

Patched in v7.8.1

The findAllBy(Pageable pageable, Criteria criteria) method has been removed from the entity repositories and org.springframework.data.relational.core.query.Criteria support in the underlying methods has been replaced with org.springframework.data.relational.core.sql.Condition. This means you won't be able to do custom filtering in the generated applications.

If you have existing reactive applications generated by the impacted version, we advise you to audit for use of Criteria and take appropriate actions.

Workarounds

The problem lies in the EntityManager.java class when creating the where clause via Conditions.just(criteria.toString()).

just accepts the literal string provided. Criteria's toString method returns a plain string and this combination is vulnerable to sql injection as the string is not sanitized and will contain whatever used passed as input using any plain SQL

So be careful when combining criterias and conditions. As a workaround we have removed the possibility to pass any user-provided criteria to the createSelect method of EntityManager.

Example

Criteria criteria = Criteria.where("name").is("foobar';DROP TABLE example;--"); // parameter is user provided input
criteria.toString(); // --> "'foobar';DROP TABLE example;--'"

References

More details in this Issue report

For more information

If you have any questions or comments about this advisory: * Open an issue in JHipster issue tracker

Severity ?
8.1 (High)
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H
Show details on source website
To clipboard 

{
  "affected": [
    {
      "package": {
        "ecosystem": "npm",
        "name": "generator-jhipster"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "7.0.0"
            },
            {
              "fixed": "7.8.1"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    }
  ],
  "aliases": [
    "CVE-2022-24815"
  ],
  "database_specific": {
    "cwe_ids": [
      "CWE-89"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2022-04-07T15:18:05Z",
    "nvd_published_at": "2022-04-11T20:15:00Z",
    "severity": "HIGH"
  },
  "details": "### Impact\nSQL Injection vulnerability in entities for applications generated with the option \"reactive with Spring WebFlux\" enabled and an SQL database using r2dbc. Applications created without \"reactive with Spring WebFlux\" and applications with NoSQL databases are not affected. \n\nIf you have generated a microservice Gateway using the affected version, you might be impacted as Gateways are reactive by default.\n\nCurrently, SQL injection is possible in the `findAllBy(Pageable pageable, Criteria criteria)` method of an entity repository class generated in these applications as the where clause using Criteria for queries are not sanitized and user input is passed on as it is by the criteria.\n\n## Impacted applications\n- Monolith and microservice applications with SQL database and reactive with Spring WebFlux combination (other combinations are not affected and the issue is only present when you generate entities)\n- Gateway applications with SQL database (issue will appear only when generating entities)\n\n### Patches\nPatched in v7.8.1\n\nThe `findAllBy(Pageable pageable, Criteria criteria)` method has been removed from the entity repositories and `org.springframework.data.relational.core.query.Criteria` support in the underlying methods has been replaced with `org.springframework.data.relational.core.sql.Condition`. This means you won\u0027t be able to do custom filtering in the generated applications.\n\nIf you have existing reactive applications generated by the impacted version, we advise you to audit for use of `Criteria` and take appropriate actions.\n\n### Workarounds\n\nThe problem lies in the `EntityManager.java` class when creating the where clause via `Conditions.just(criteria.toString())`.\n\n`just` accepts the literal string provided. Criteria\u0027s `toString` method returns a plain string and this combination is vulnerable to sql injection as the string is not sanitized and will contain whatever used passed as input using any plain SQL\n\nSo be careful when combining criterias and conditions. As a workaround we have removed the possibility to pass any user-provided criteria to the `createSelect` method of `EntityManager`.\n\n### Example \n\n```java\nCriteria criteria = Criteria.where(\"name\").is(\"foobar\u0027;DROP TABLE example;--\"); // parameter is user provided input\ncriteria.toString(); // --\u003e \"\u0027foobar\u0027;DROP TABLE example;--\u0027\"\n```\n\n### References\n[More details in this Issue report](https://github.com/jhipster/generator-jhipster/issues/18269)\n\n### For more information\nIf you have any questions or comments about this advisory:\n* Open an issue in [JHipster issue tracker](https://github.com/jhipster/generator-jhipster/issues)\n",
  "id": "GHSA-qjmq-8hjr-qcv6",
  "modified": "2022-04-18T22:20:12Z",
  "published": "2022-04-07T15:18:05Z",
  "references": [
    {
      "type": "WEB",
      "url": "https://github.com/jhipster/generator-jhipster/security/advisories/GHSA-qjmq-8hjr-qcv6"
    },
    {
      "type": "ADVISORY",
      "url": "https://nvd.nist.gov/vuln/detail/CVE-2022-24815"
    },
    {
      "type": "WEB",
      "url": "https://github.com/jhipster/generator-jhipster/issues/18269"
    },
    {
      "type": "WEB",
      "url": "https://github.com/jhipster/generator-jhipster/commit/c220a210fd7742c53eea72bd5fadbb96220faa98"
    },
    {
      "type": "PACKAGE",
      "url": "https://github.com/jhipster/generator-jhipster"
    }
  ],
  "schema_version": "1.4.0",
  "severity": [
    {
      "score": "CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H",
      "type": "CVSS_V3"
    }
  ],
  "summary": "SQL Injection when creating an application with Reactive SQL backend "
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or observed by the user.
  • Confirmed: The vulnerability has been validated from an analyst's perspective.
  • Published Proof of Concept: A public proof of concept is available for this vulnerability.
  • Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
  • Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
  • Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
  • Not confirmed: The user expressed doubt about the validity of the vulnerability.
  • Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.



Detection rules are retrieved from Rulezet.