GHSA-R74Q-GXCG-73HX

Vulnerability from github – Published: 2019-09-30 19:41 – Updated: 2023-08-28 10:44
VLAI?
Summary
Improper Input Validation in simple_form
Details

Incorrect Access Control in file_method? in lib/simple_form/form_builder.rb; a user-supplied string is invoked as a method call

Impact

For pages that build a form using user input, it is possible for an attacker to manipulate the input and send any method present in the form object. For example:

<%= simple_form_for @user do |f| %>
  <%= f.label @user_supplied_string %>
  ...
<% end %>

The string provided in the variable @user_supplied_string would be invoked as a method call inside the @user object (unless the string contains any of the following: password, time_zone, country, email, phone and url).

By manipulation that input, an attacker could do any of the following:

  • Code execution (call actions like #destroy)
  • Denial of Service (by executing a computation intensive method)
  • Information Disclosure (check the presence of methods, leak user information)

Patches

The problem was fixed in version 5.0. Although it's a major version, there should be no issues with upgrading for 4.x. The reason it was released in a major version is that the configuration SimpleForm.file_methods was deprecated in order to fix the problem.

Workarounds

The issue only happens with pages that build forms based on user-provided input. If your application doesn't do that, you're not affected. A workaround is to explicitly pass which type you want for an input since the issue lies on Simple Form's automatically discovery of input types. This can be done using the as option, like the following:

<%= form.input :avatar, as: :file %>

References

[TDB]

For more information

If you have any questions or comments about this advisory: * Open an issue in https://github.com/plataformatec/simple_form * Email us at opensource@plataformatec.com.br

Severity ?
9.8 (Critical)
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H
Show details on source website
To clipboard 

{
  "affected": [
    {
      "package": {
        "ecosystem": "RubyGems",
        "name": "simple_form"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "0"
            },
            {
              "fixed": "5.0.0"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    }
  ],
  "aliases": [
    "CVE-2019-16676"
  ],
  "database_specific": {
    "cwe_ids": [
      "CWE-20"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2020-06-16T21:53:49Z",
    "nvd_published_at": null,
    "severity": "CRITICAL"
  },
  "details": "## Incorrect Access Control in `file_method?` in `lib/simple_form/form_builder.rb`; a user-supplied string is invoked as a method call\n\n### Impact\nFor pages that build a form using user input, it is possible for an attacker to manipulate the input and send any method present in the form object. For example:\n\n```erb\n\u003c%= simple_form_for @user do |f| %\u003e\n  \u003c%= f.label @user_supplied_string %\u003e\n  ...\n\u003c% end %\u003e\n```\n\nThe string provided in the variable `@user_supplied_string` would be invoked as a method call inside the `@user` object (unless the string contains any of the following: `password`, `time_zone`, `country`, `email`, `phone` and `url`).\n\nBy manipulation that input, an attacker could do any of the following:\n\n- Code execution (call actions like `#destroy`)\n- Denial of Service (by executing a computation intensive method)\n- Information Disclosure (check the presence of methods, leak user information)\n\n### Patches\nThe problem was fixed in version `5.0`. Although it\u0027s a major version, there should be no issues with upgrading for `4.x`. The reason it was released in a major version is that the configuration `SimpleForm.file_methods` was deprecated in order to fix the problem.\n\n### Workarounds\nThe issue only happens with pages that build forms based on user-provided input. If your application doesn\u0027t do that, you\u0027re not affected.\nA workaround is to explicitly pass which type you want for an input since the issue lies on Simple Form\u0027s automatically discovery of input types. This can be done using the `as` option, like the following:\n```erb\n\u003c%= form.input :avatar, as: :file %\u003e\n```\n\n### References\n[TDB]\n\n### For more information\nIf you have any questions or comments about this advisory:\n* Open an issue in [https://github.com/plataformatec/simple_form](https://github.com/plataformatec/simple_form)\n* Email us at [opensource@plataformatec.com.br](mailto:opensource@plataformatec.com.br)",
  "id": "GHSA-r74q-gxcg-73hx",
  "modified": "2023-08-28T10:44:04Z",
  "published": "2019-09-30T19:41:15Z",
  "references": [
    {
      "type": "WEB",
      "url": "https://github.com/plataformatec/simple_form/security/advisories/GHSA-r74q-gxcg-73hx"
    },
    {
      "type": "ADVISORY",
      "url": "https://nvd.nist.gov/vuln/detail/CVE-2019-16676"
    },
    {
      "type": "WEB",
      "url": "https://github.com/heartcombo/simple_form/commit/8c91bd76a5052ddf3e3ab9fd8333f9aa7b2e2dd6"
    },
    {
      "type": "ADVISORY",
      "url": "https://github.com/advisories/GHSA-r74q-gxcg-73hx"
    },
    {
      "type": "PACKAGE",
      "url": "https://github.com/heartcombo/simple_form"
    },
    {
      "type": "WEB",
      "url": "https://github.com/plataformatec/simple_form/commits/master"
    },
    {
      "type": "WEB",
      "url": "https://github.com/rubysec/ruby-advisory-db/blob/master/gems/simple_form/CVE-2019-16676.yml"
    },
    {
      "type": "WEB",
      "url": "http://blog.plataformatec.com.br/2019/09/incorrect-access-control-in-simple-form-cve-2019-16676"
    }
  ],
  "schema_version": "1.4.0",
  "severity": [
    {
      "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H",
      "type": "CVSS_V3"
    }
  ],
  "summary": "Improper Input Validation in simple_form"
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or observed by the user.
  • Confirmed: The vulnerability has been validated from an analyst's perspective.
  • Published Proof of Concept: A public proof of concept is available for this vulnerability.
  • Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
  • Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
  • Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
  • Not confirmed: The user expressed doubt about the validity of the vulnerability.
  • Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.



Detection rules are retrieved from Rulezet.